netdev - Re: [PATCH v8 01/15] octeontx2-af: Add Marvell OcteonTX2 RVU AF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 8 Oct 2018 16:29:11 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Sunil Kovvuri <sunil.kovvuri@...il.com>
Cc:     Networking <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>, linux-soc@...r.kernel.org,
        sgoutham@...vell.com
Subject: Re: [PATCH v8 01/15] octeontx2-af: Add Marvell OcteonTX2 RVU AF driver

On Mon, Oct 8, 2018 at 3:50 PM Sunil Kovvuri <sunil.kovvuri@...il.com> wrote:
>
> On Mon, Oct 8, 2018 at 5:52 PM Arnd Bergmann <arnd@...db.de> wrote:
> >
> > On Sun, Oct 7, 2018 at 4:59 PM <sunil.kovvuri@...il.com> wrote:
> >
> > > --- /dev/null
> > > +++ b/drivers/net/ethernet/marvell/octeontx2/Kconfig
> > > @@ -0,0 +1,12 @@
> > > +#
> > > +# Marvell OcteonTX2 drivers configuration
> > > +#
> > > +
> > > +config OCTEONTX2_AF
> > > +       tristate "Marvell OcteonTX2 RVU Admin Function driver"
> > > +       depends on ARM64 && PCI
> >
> > You should try to allow building it on x86 and other architectures, even though
> > the driver won't be used there this helps get reports from static
> > build infrastructure.
> > You could use e.g.
> >
> >       depends on (64BIT && COMPILE_TEST) || ARM64
> >       depends on PCI
> >
> >            Arnd
>
> Thanks for the suggestion.
> But going forward we will have few arm64 assembly instructions used in
> the driver.

What is those inline assembly for? Is there a chance they can
be abstracted through some other interface?

     Arnd