netdev - Re: [PATCH net-next v3 0/6] net: phy: mscc: various improvements to Microsemi PHY driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181008.102936.2115401220175323898.davem@davemloft.net>
Date:   Mon, 08 Oct 2018 10:29:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     quentin.schulz@...tlin.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, allan.nielsen@...rochip.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com
Subject: Re: [PATCH net-next v3 0/6] net: phy: mscc: various improvements
 to Microsemi PHY driver

From: Quentin Schulz <quentin.schulz@...tlin.com>
Date: Mon,  8 Oct 2018 12:07:22 +0200

> The Microsemi PHYs have multiple banks of registers (called pages).
> Registers can only be accessed from one page, if we need a register from
> another page, we need to switch the page and the registers of all other
> pages are not accessible anymore.
> 
> Basically, to read register 5 from page 0, 1, 2, etc., you do the same
> phy_read(phydev, 5); but you need to set the desired page beforehand.
> 
> In order to guarantee that two concurrent functions do not change the
> page, we need to do some locking per page. This can be achieved with the
> use of phy_select_page and phy_restore_page functions but phy_write/read
> calls in-between those two functions shall be replaced by their
> lock-free alternative __phy_write/read.
> 
> The Microsemi PHYs have several counters so let's make them available as PHY
> statistics.
> 
> The VSC 8530/31/40/41 also need to update their EEE init sequence in order to
> avoid packet losses and improve performance.
> 
> This patch series also makes some minor cosmetic changes to the driver.

Series applied, thank you.