netdev - Re: [PATCH v2 net-next 11/23] rtnetlink: Update rtnl_stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181008.110258.1157567575453794867.davem@davemloft.net>
Date:   Mon, 08 Oct 2018 11:02:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     christian@...uner.io, dsahern@...nel.org, netdev@...r.kernel.org,
        jbenc@...hat.com, stephen@...workplumber.org
Subject: Re: [PATCH v2 net-next 11/23] rtnetlink: Update rtnl_stats_dump
 for strict data checking

From: David Ahern <dsahern@...il.com>
Date: Mon, 8 Oct 2018 07:25:34 -0600

> On 10/8/18 4:17 AM, Christian Brauner wrote:
>>> @@ -4696,13 +4697,32 @@ static int rtnl_stats_dump(struct sk_buff *skb, struct netlink_callback *cb)
>>>  
>>>  	cb->seq = net->dev_base_seq;
>>>  
>>> -	if (nlmsg_len(cb->nlh) < sizeof(*ifsm))
>>> +	if (nlmsg_len(cb->nlh) < sizeof(*ifsm)) {
>>> +		NL_SET_ERR_MSG(extack, "Invalid header for stats dump");
>>>  		return -EINVAL;
>>> +	}
>>>  
>>>  	ifsm = nlmsg_data(cb->nlh);
>>> +
>>> +	/* only requests using NLM_F_DUMP_PROPER_HDR can pass data to
>> 
>> That looks like an accidental leftover before we changed this to a
>> socket option. :)
>> 
> 
> ugh. thanks for noticing.

David, I applied this series, please send me relative fixups at this point
if necessary.

Thanks.