netdev - Re: [PATCH v8 05/15] octeontx2-af: Add mailbox IRQ and msg handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181007.211146.1803805129203289271.davem@davemloft.net>
Date:   Sun, 07 Oct 2018 21:11:46 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sunil.kovvuri@...il.com
Cc:     netdev@...r.kernel.org, arnd@...db.de, linux-soc@...r.kernel.org,
        sgoutham@...vell.com
Subject: Re: [PATCH v8 05/15] octeontx2-af: Add mailbox IRQ and msg handlers

From: sunil.kovvuri@...il.com
Date: Sun,  7 Oct 2018 20:29:14 +0530

> +	req_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->rx_start);

I commented in the previous patch series version, for patch #4, that
such casts are unnecessary and should be removed.

You are in for a very long review process if you only consider feedback
given to you for the specific patch for which it is given, rather than
your entire series.

Please put forth the effort to fix the problems pointed out to you in
your entire series.

Thank you.