netdev - RE: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 8 Oct 2018 07:50:15 +0000
From:   "Y.b. Lu" <yangbo.lu@....com>
To:     Andrew Lunn <andrew@...n.ch>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Richard Cochran <richardcochran@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: RE: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/

Let me just add an additional patch in v3.
I had sent the new v3 patch-set out. Please help to review.

Thanks a lot.

Best regards,
Yangbo Lu

> -----Original Message-----
> From: Y.b. Lu
> Sent: Monday, October 8, 2018 11:11 AM
> To: 'Andrew Lunn' <andrew@...n.ch>; Ioana Ciocoi Radulescu
> <ruxandra.radulescu@....com>
> Cc: linux-kernel@...r.kernel.org; devel@...verdev.osuosl.org;
> netdev@...r.kernel.org; Richard Cochran <richardcochran@...il.com>;
> David S . Miller <davem@...emloft.net>; Ioana Ciocoi Radulescu
> <ruxandra.radulescu@....com>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>
> Subject: RE: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of staging/
> 
> Hi Andrew,
> 
> Sorry for late. Just come back from holiday.
> 
> Hi Ioana,
> 
> Could you generate an additional patch for dpaa2_eth to address Andrew's
> comments?
> There was also a warning when checked patch. FSL_DPAA2_ETH needed more
> description.
> 
> WARNING: please write a paragraph that describes the config symbol fully
> #66: FILE: drivers/net/ethernet/freescale/dpaa2/Kconfig:1:
> +config FSL_DPAA2_ETH
> 
> Thanks a lot.
> 
> Best regards,
> Yangbo Lu
> 
> > -----Original Message-----
> > From: Andrew Lunn <andrew@...n.ch>
> > Sent: Sunday, September 30, 2018 3:46 AM
> > To: Y.b. Lu <yangbo.lu@....com>
> > Cc: linux-kernel@...r.kernel.org; devel@...verdev.osuosl.org;
> > netdev@...r.kernel.org; Richard Cochran <richardcochran@...il.com>;
> > David S . Miller <davem@...emloft.net>; Ioana Ciocoi Radulescu
> > <ruxandra.radulescu@....com>; Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org>
> > Subject: Re: [v2, 1/5] net: dpaa2: move DPAA2 PTP driver out of
> > staging/
> >
> > > +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
> > > @@ -0,0 +1,15 @@
> > > +config FSL_DPAA2_ETH
> > > +	tristate "Freescale DPAA2 Ethernet"
> > > +	depends on FSL_MC_BUS && FSL_MC_DPIO
> >
> > Could you add in here COMPILE_TEST?
> >
> > > +	depends on NETDEVICES && ETHERNET
> >
> > With the move out of staging, i don't think these two are required.
> >
> >      Andrew