netdev - Re: [PATCH net-next 00/11] net: sched: cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79d67dde-fce4-5e58-da13-53545cef2158@mojatatu.com>
Date:   Mon, 8 Oct 2018 05:47:35 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Al Viro <viro@...IV.linux.org.uk>,
        David Miller <davem@...emloft.net>
Cc:     jiri@...nulli.us, xiyou.wangcong@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 00/11] net: sched: cls_u32 Various improvements

On 2018-10-08 2:11 a.m., Al Viro wrote:
> On Sun, Oct 07, 2018 at 10:55:52PM -0700, David Miller wrote:
>> From: Al Viro <viro@...IV.linux.org.uk>
>> Date: Mon, 8 Oct 2018 06:45:15 +0100
>>
>>> Er...  Both are due to missing in the very beginning of the series (well, on
>>> top of "net: sched: cls_u32: fix hnode refcounting") commit
>>
>> All dependencies like this must be explicitly stated.
>>
>> And in such situations you actually should wait for the dependency to
>> get into 'net', eventually get merged into 'net-next', and then you
>> can submit the stuff that depends upon it.
>>
>> Not the way this was done.
> 
> Point (and this commit is simply missing - it's not that it went into
> net).  FWIW, this was simply "this is what the breakage is caused by",
> not an attempt to amend the submission or anything like that...
> 

My bad. I was wondering why it compiled for me. There is no dependency
on the single patch that went to net. I will submit an updated version.

cheers,
jamal