netdev - Re: [PATCH net-next v7 25/28] crypto: port Poly1305 to Zinc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9qo+8JKL_J10UghiJjxQABA5meOg=TqgpfvbV=nPJx7Tg@mail.gmail.com>
Date:   Tue, 9 Oct 2018 02:02:32 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Samuel Neves <sneves@....uc.pt>,
        Andrew Lutomirski <luto@...nel.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH net-next v7 25/28] crypto: port Poly1305 to Zinc

Hi Eric,

On Tue, Oct 9, 2018 at 1:21 AM Eric Biggers <ebiggers@...nel.org> wrote:
> This crashes on very short inputs.  crypto_poly1305_final() is missing:
>
>         if (dctx->rem_key_bytes)
>                 return -ENOKEY;

Good catch, thanks. Queued for v8.

Jason