netdev - Re: [bpf-next V2 PATCH 0/3] bpf/xdp: fix generic-XDP and demonstrate VLAN manipulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW7OsND_PD37NXBRkvMfYVtpci-ObX8TPBYRDWXAb3NVPw@mail.gmail.com>
Date:   Tue, 9 Oct 2018 11:47:49 -0700
From:   Song Liu <liu.song.a23@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>
Cc:     Networking <netdev@...r.kernel.org>,
        Daniel Borkmann <borkmann@...earbox.net>, yoel@...knet.dk,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        John Fastabend <john.fastabend@...il.com>
Subject: Re: [bpf-next V2 PATCH 0/3] bpf/xdp: fix generic-XDP and demonstrate
 VLAN manipulation

For the series:

Acked-by: Song Liu <songliubraving@...com>


On Tue, Oct 9, 2018 at 3:04 AM Jesper Dangaard Brouer <brouer@...hat.com> wrote:
>
> While implementing PoC building blocks for eBPF code XDP+TC that can
> manipulate VLANs headers, I discovered a bug in generic-XDP.
>
> The fix should be backported to stable kernels.  Even-though
> generic-XDP was introduced in v4.12, I think the bug is not exposed
> until v4.14 in the mentined fixes commit.
>
> ---
>
> Jesper Dangaard Brouer (3):
>       net: fix generic XDP to handle if eth header was mangled
>       bpf: make TC vlan bpf_helpers avail to selftests
>       selftests/bpf: add XDP selftests for modifying and popping VLAN headers
>
>
>  net/core/dev.c                               |   14 +
>  tools/testing/selftests/bpf/Makefile         |    6 -
>  tools/testing/selftests/bpf/bpf_helpers.h    |    4
>  tools/testing/selftests/bpf/test_xdp_vlan.c  |  292 ++++++++++++++++++++++++++
>  tools/testing/selftests/bpf/test_xdp_vlan.sh |  195 +++++++++++++++++
>  5 files changed, 509 insertions(+), 2 deletions(-)
>  create mode 100644 tools/testing/selftests/bpf/test_xdp_vlan.c
>  create mode 100755 tools/testing/selftests/bpf/test_xdp_vlan.sh
>
> --