netdev - [PATCH net-next 0/3] nfp: flower: speed up stats update loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181009015736.30268-1-jakub.kicinski@netronome.com>
Date:   Mon,  8 Oct 2018 18:57:33 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: [PATCH net-next 0/3] nfp: flower: speed up stats update loop

Hi!

This set from Pieter improves performance of processing FW stats
update notifications.  The FW seems to send those at relatively
high rate (roughly ten per second per flow), therefore if we want
to approach the million flows mark we have to be very careful
about our data structures.

We tried rhashtable for stat updates, but according to our experiments
rhashtable lookup on a u32 takes roughly 60ns on an Xeon E5-2670 v3.
Which translate to a hard limit of 16M lookups per second on this CPU,
and, according to perf record jhash and memcmp account for 60% of CPU
usage on the core handling the updates.

Given that our statistic IDs are already array indices, and considering
each statistic is only 24B in size, we decided to forego the use
of hashtables and use a directly indexed array.  The CPU savings are
considerable.

With the recent improvements in TC core and with our own bottlenecks
out of the way Pieter removes the artificial limit of 128 flows, and
allows the driver to install as many flows as FW supports.

Pieter Jansen van Vuuren (3):
  nfp: flower: use rhashtable for flow caching
  nfp: flower: use stats array instead of storing stats per flow
  nfp: flower: use host context count provided by firmware

 drivers/net/ethernet/netronome/nfp/bpf/main.c |   5 -
 .../net/ethernet/netronome/nfp/flower/main.c  |  15 +-
 .../net/ethernet/netronome/nfp/flower/main.h  |  23 +--
 .../ethernet/netronome/nfp/flower/metadata.c  | 145 ++++++++++++------
 .../ethernet/netronome/nfp/flower/offload.c   |  31 ++--
 drivers/net/ethernet/netronome/nfp/nfp_app.c  |   5 +
 drivers/net/ethernet/netronome/nfp/nfp_app.h  |   1 +
 7 files changed, 148 insertions(+), 77 deletions(-)

-- 
2.17.1