netdev - Re: [PATCH v4 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <389316c10115ddbb06d4895def185b45d3a60954.camel@mellanox.com>
Date:   Tue, 9 Oct 2018 06:21:43 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "davem@...emloft.net" <davem@...emloft.net>,
        "vasundhara-v.volam@...adcom.com" <vasundhara-v.volam@...adcom.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>,
        "gerlitz.or@...il.com" <gerlitz.or@...il.com>,
        "michael.chan@...adcom.com" <michael.chan@...adcom.com>
Subject: Re: [PATCH v4 net-next 8/9] devlink: Add
 Documentation/networking/devlink-params.txt

On Thu, 2018-10-04 at 11:13 +0530, Vasundhara Volam wrote:
> This patch adds a new file to add information about some of the
> generic configuration parameters set via devlink.
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Jonathan Corbet <corbet@....net>
> Cc: linux-doc@...r.kernel.org
> Cc: Jiri Pirko <jiri@...lanox.com>
> Cc: Michael Chan <michael.chan@...adcom.com>
> Signed-off-by: Vasundhara Volam <vasundhara-v.volam@...adcom.com>
> ---
>  Documentation/networking/devlink-params.txt | 42
> +++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/networking/devlink-params.txt
> 
> diff --git a/Documentation/networking/devlink-params.txt
> b/Documentation/networking/devlink-params.txt
> new file mode 100644
> index 0000000..ae444ff
> --- /dev/null
> +++ b/Documentation/networking/devlink-params.txt
> @@ -0,0 +1,42 @@
> +Devlink configuration parameters
> +================================
> +Following is the list of configuration parameters via devlink
> interface.
> +Each parameter can be generic or driver specific and are device
> level
> +parameters.
> +
> +Note that the driver-specific files should contain the generic
> params
> +they support to, with supported config modes.
> +
> +Each parameter can be set in different configuration modes:
> +	runtime		- set while driver is running, no reset
> required.
> +	driverinit	- applied while driver initializes, requires
> restart
> +			driver by devlink reload command.
> +	permanent	- written to device's non-volatile memory, hard reset
> +			required.
> +
> +Following is the list of parameters:
> +====================================
> +enable_sriov		[DEVICE, GENERIC]
> +			Enable Single Root I/O Virtualisation (SRIOV)
> in
> +			the device.
> +			Type: Boolean
> +
> +ignore_ari		[DEVICE, GENERIC]
> +			Ignore Alternative Routing-ID Interpretation
> (ARI)
> +			capability. If enabled, adapter will ignore ARI
> +			capability even when platforms has the support
> +			enabled and creates same number of partitions
> when
> +			platform does not support ARI.
> +			Type: Boolean
> +
> +msix_vec_per_pf_max	[DEVICE, GENERIC]
> +			Provides the maximum number of MSIX interrupts
> that
> +			a device can create. Value is same across all
> +			physical functions (PFs) in the device.
> +			Type: u32
> +
> +msix_vec_per_pf_min	[DEVICE, GENERIC]
> +			Provides the minimum number of MSIX interrupts
> required
> +			for the device initialization. Value is same
> across all
> +			physical functions (PFs) in the device.
> +			Type: u32

some parameters can't be dynamic, meaning they can't support all
configuration modes listed above, for example msix min/max can only be
satisfied at driver boot, so runtime configuration doesn't make sense. 
shouldn't we have this documented in here ? i mean which parameters
support which modes ?