netdev - Re: [PATCH stable 4.9 00/29] backport of IP fragmentation fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 10 Oct 2018 16:23:10 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org,
        davem@...emloft.net, gregkh@...uxfoundation.org,
        stable@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH stable 4.9 00/29] backport of IP fragmentation fixes

On 10/10/2018 04:18 PM, Stephen Hemminger wrote:
> On Tue, 9 Oct 2018 21:15:04 -0700
> Florian Fainelli <f.fainelli@...il.com> wrote:
> 
>>>
>>> Strange, I do not see "ip: use rb trees for IP frag queue." in this list ?  
>>
>> And it was not in Stephen's backport to 4.14 either, wait, looks like it
>> was somehow squashed into "net: sk_buff rbnode reorg". Stephen, was
>> there a reason for that?
>>
>> Let me go back and add bffa72cf7f9df842f0016ba03586039296b4caaf as well
>> as eeea10b83a139451130df1594f26710c8fa390c8 to the rebase todo and see
>> how things go from there.
>>
>> Thanks for taking a look.
> 
> I don't remember, spent time doing cherry-pick and fixups. Maybe the reorg
> commit got squashed as part of one rebase.
> 

No worries, I ended dropping these two commits because they would have
required cherry-picking "udp: copy skb->truesize in the first cache
line" which did not seem appropriate. I would appreciate if you could
take a look at v2 and confirm this does look good, in particular the
struct sk_buff layout.

Thanks!
-- 
Florian