netdev - Re: [PATCH net] net/mlx4_core: Fix warnings during boot on driverinit param set failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181011.102550.398678546373893514.davem@davemloft.net>
Date:   Thu, 11 Oct 2018 10:25:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tariqt@...lanox.com
Cc:     netdev@...r.kernel.org, eranbe@...lanox.com, moshe@...lanox.com
Subject: Re: [PATCH net] net/mlx4_core: Fix warnings during boot on
 driverinit param set failures

From: Tariq Toukan <tariqt@...lanox.com>
Date: Thu, 11 Oct 2018 15:01:19 +0300

> From: Moshe Shemesh <moshe@...lanox.com>
> 
> During boot, mlx4_core sets the driverinit configuration parameters and
> updates the devlink module on the initial values calling
> devlink_param_driverinit_value_set().
> If devlink_param_driverinit_value_set() returns an error mlx4_core
> reports kernel module warning.
> 
> This caused false alarm during boot in case kernel was compiled with
> CONFIG_NET_DEVLINK off.
> Fix by removing warning reported in case
> devlink_param_driverinit_value_set() fails.
> 
> This actually makes the function mlx4_devlink_set_init_value()
> redundant to using directly devlink_param_driverinit_value_set() and so
> removed.
> 
> It fixes the following kernel trace:
> 
>  mlx4_core 0000:00:06.0: devlink set parameter 0 value failed (err = -95)
>  mlx4_core 0000:00:06.0: devlink set parameter 1 value failed (err = -95)
>  mlx4_core 0000:00:06.0: devlink set parameter 4 value failed (err = -95)
>  mlx4_core 0000:00:06.0: devlink set parameter 5 value failed (err = -95)
>  mlx4_core 0000:00:06.0: devlink set parameter 3 value failed (err = -95)
> 
> Fixes: bd1b51dc66df ("mlx4: Add mlx4 initial parameters table and register it")
> Signed-off-by: Moshe Shemesh <moshe@...lanox.com>
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>

Applied.