netdev - Re: [PATCH] isdn/hisax: amd7930_fn: Remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181010.222919.1392544811823497274.davem@davemloft.net>
Date:   Wed, 10 Oct 2018 22:29:19 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     natechancellor@...il.com
Cc:     isdn@...ux-pingi.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isdn/hisax: amd7930_fn: Remove unnecessary parentheses

From: Nathan Chancellor <natechancellor@...il.com>
Date: Mon,  8 Oct 2018 15:59:05 -0700

> Clang warns when multiple sets of parentheses are used for a single
> conditional statement.
> 
> drivers/isdn/hisax/amd7930_fn.c:628:32: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
>                 if ((cs->dc.amd7930.ph_state == 8)) {
>                      ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> drivers/isdn/hisax/amd7930_fn.c:628:32: note: remove extraneous
> parentheses around the comparison to silence this warning
>                 if ((cs->dc.amd7930.ph_state == 8)) {
>                     ~                        ^   ~
> drivers/isdn/hisax/amd7930_fn.c:628:32: note: use '=' to turn this
> equality comparison into an assignment
>                 if ((cs->dc.amd7930.ph_state == 8)) {
>                                              ^~
>                                              =
> 1 warning generated.
> 
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Applied.