netdev - Re: [PATCH net-next] net/mpls: Implement handler for strict data checking on dumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181010.224638.856952270298349399.davem@davemloft.net>
Date:   Wed, 10 Oct 2018 22:46:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, arnd@...db.de, dsahern@...il.com
Subject: Re: [PATCH net-next] net/mpls: Implement handler for strict data
 checking on dumps

From: David Ahern <dsahern@...nel.org>
Date: Tue,  9 Oct 2018 11:10:43 -0700

> From: David Ahern <dsahern@...il.com>
> 
> Without CONFIG_INET enabled compiles fail with:
> 
> net/mpls/af_mpls.o: In function `mpls_dump_routes':
> af_mpls.c:(.text+0xed0): undefined reference to `ip_valid_fib_dump_req'
> 
> The preference is for MPLS to use the same handler as ipv4 and ipv6
> to allow consistency when doing a dump for AF_UNSPEC which walks
> all address families invoking the route dump handler. If INET is
> disabled then fallback to an MPLS version which can be tighter on
> the data checks.
> 
> Fixes: e8ba330ac0c5 ("rtnetlink: Update fib dumps for strict data checking")
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied.