netdev - Re: [PATCH net-next] net: sched: avoid writing on noop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181010.224933.574942568684128097.davem@davemloft.net>
Date:   Wed, 10 Oct 2018 22:49:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, john.fastabend@...il.com,
        eric.dumazet@...il.com
Subject: Re: [PATCH net-next] net: sched: avoid writing on noop_qdisc

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue,  9 Oct 2018 15:20:50 -0700

> While noop_qdisc.gso_skb and noop_qdisc.skb_bad_txq are not used
> in other places, it seems not correct to overwrite their fields
> in dev_init_scheduler_queue().
> 
> noop_qdisc is essentially a shared and read-only object, even if
> it is not marked as const because of some implementation detail.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks.