netdev - Re: [net 1/1] tipc: set link tolerance correctly in broadcast link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181010.225652.206935836434769992.davem@davemloft.net>
Date:   Wed, 10 Oct 2018 22:56:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org, gordan.mihaljevic@...tech.com.au,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net 1/1] tipc: set link tolerance correctly in broadcast link

From: Jon Maloy <jon.maloy@...csson.com>
Date: Wed, 10 Oct 2018 17:34:01 +0200

> In the patch referred to below we added link tolerance as an additional
> criteria for declaring broadcast transmission "stale" and resetting the
> affected links.
> 
> However, the 'tolerance' field of the broadcast link is never set, and
> remains at zero. This renders the whole commit without the intended
> improving effect, but luckily also with no negative effect.
> 
> In this commit we add the missing initialization.
> 
> Fixes: a4dc70d46cf1 ("tipc: extend link reset criteria for stale packet
> retransmission")
> 
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied.