netdev - Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181012.111130.2147603962642962519.davem@davemloft.net>
Date:   Fri, 12 Oct 2018 11:11:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     dhowells@...hat.com, arnd@...db.de, netdev@...r.kernel.org,
        linux-afs@...ts.infradead.org
Subject: Re: [PATCH net] rxrpc: Fix incorrect conditional on IPV6

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 12 Oct 2018 08:19:20 -0700

> 
> 
> On 10/12/2018 07:52 AM, David Howells wrote:
>> The udpv6_encap_enable() function is part of the ipv6 code, and if that is
>> configured as a loadable module and rxrpc is built in then a build failure
>> will occur because the conditional check is wrong:
>> 
>>   net/rxrpc/local_object.o: In function `rxrpc_lookup_local':
>>   local_object.c:(.text+0x2688): undefined reference to `udpv6_encap_enable'
>> 
>> Use the correct config symbol (CONFIG_AF_RXRPC_IPV6) in the conditional
>> check rather than CONFIG_IPV6 as that will do the right thing.
>> 
>> Fixes: 5271953cad31 ("rxrpc: Use the UDP encap_rcv hook")
>> Signed-off-by: David Howells <dhowells@...hat.com>
>> cc: Arnd Bergmann <arnd@...db.de>
> 
> Nit : Correct attribution would require a Reported-by: tag

Right.