netdev - RE: [PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k1mnptlq.fsf@vitty.brq.redhat.com>
Date:   Fri, 12 Oct 2018 08:27:45 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     Haiyang Zhang <haiyangz@...rosoft.com>
Cc:     "davem\@davemloft.net" <davem@...emloft.net>,
        "netdev\@vger.kernel.org" <netdev@...r.kernel.org>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "olaf\@aepfle.de" <olaf@...fle.de>,
        "devel\@linuxdriverproject.org" <devel@...uxdriverproject.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info

Haiyang Zhang <haiyangz@...rosoft.com> writes:

>> -----Original Message-----
>> From: Haiyang Zhang <haiyangz@...uxonhyperv.com>
>> Sent: Thursday, October 11, 2018 4:15 PM
>> To: davem@...emloft.net; netdev@...r.kernel.org
>> Cc: Haiyang Zhang <haiyangz@...rosoft.com>; KY Srinivasan
>> <kys@...rosoft.com>; Stephen Hemminger <sthemmin@...rosoft.com>;
>> olaf@...fle.de; vkuznets <vkuznets@...hat.com>;
>> devel@...uxdriverproject.org; linux-kernel@...r.kernel.org
>> Subject: [PATCH net-next] hv_netvsc: fix vf serial matching with pci slot info
>> 
>> From: Haiyang Zhang <haiyangz@...rosoft.com>
>> 
>> The VF device's serial number is saved as a string in PCI slot's kobj name, not
>> the slot->number. This patch corrects the netvsc driver, so the VF device can be
>> successfully paired with synthetic NIC.
>> 
>> Fixes: 00d7ddba1143 ("hv_netvsc: pair VF based on serial number")
>> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
>
> Thanks Stephen for the reminder -- I added the "reported-by" here:
>
> Reported-by: Vitaly Kuznetsov <vkuznets@...hat.com>

Thanks) 

The difference in the hack I sent to Stephen was that instead of using
kstrtou32() and checking the return value I opted for snprintf() and
doing strncmp().

-- 
Vitaly