netdev - Re: [PATCH net-next v7] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d982edf8e0c774afaf5e77493e53c8ecb7b7a4b1.camel@mendozajonas.com>
Date:   Fri, 12 Oct 2018 13:39:15 +1100
From:   Samuel Mendoza-Jonas <sam@...dozajonas.com>
To:     Justin.Lee1@...l.com, davem@...emloft.net
Cc:     linux-aspeed@...ts.ozlabs.org, netdev@...r.kernel.org,
        openbmc@...ts.ozlabs.org, amithash@...com, christian@....nu,
        vijaykhemka@...com
Subject: Re: [PATCH net-next v7] net/ncsi: Extend NC-SI Netlink interface to
 allow user space to send NC-SI command

On Thu, 2018-10-11 at 18:07 +0000, Justin.Lee1@...l.com wrote:
> The new command (NCSI_CMD_SEND_CMD) is added to allow user space application
> to send NC-SI command to the network card.
> Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and response.
> 
> The work flow is as below. 
> 
> Request:
> User space application
> 	-> Netlink interface (msg)
> 	-> new Netlink handler - ncsi_send_cmd_nl()
> 	-> ncsi_xmit_cmd()
> 
> Response:
> Response received - ncsi_rcv_rsp()
> 	-> internal response handler - ncsi_rsp_handler_xxx()
> 	-> ncsi_rsp_handler_netlink()
> 	-> ncsi_send_netlink_rsp ()
> 	-> Netlink interface (msg)
> 	-> user space application
> 
> Command timeout - ncsi_request_timeout()
> 	-> ncsi_send_netlink_timeout ()
> 	-> Netlink interface (msg with zero data length)
> 	-> user space application
> 
> Error:
> Error detected
> 	-> ncsi_send_netlink_err ()
> 	-> Netlink interface (err msg)
> 	-> user space application
> 
> 
> Signed-off-by: Justin Lee <justin.lee1@...l.com> 
> 

Reviewed-by: Samuel Mendoza-Jonas <sam@...dozajonas.com>