netdev - Re: [PATCH 1/1] crypto:chelsio: Update ntx queue received from cxgb4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f628759-bd3a-d7d3-6be2-e3dba759fdf3@chelsio.com>
Date:   Sat, 13 Oct 2018 12:53:36 +0530
From:   Harsh Jain <harsh@...lsio.com>
To:     Lino Sanfilippo <LinoSanfilippo@....de>,
        herbert@...dor.apana.org.au, atul.gupta@...lsio.com,
        indranil@...lsio.com, swise@...ngridcomputing.com,
        varun@...lsio.com, ganeshgr@...lsio.com, netdev@...r.kernel.org,
        linux-crypto@...r.kernel.org
Subject: Re: [PATCH 1/1] crypto:chelsio: Update ntx queue received from cxgb4



On 13-10-2018 05:46, Lino Sanfilippo wrote:
> Hi,
>
>> +	if (uld_type == CXGB4_ULD_CRYPTO) {
>> +		i = min_t(int, adap->vres.ncrypto_fc,
>> +			  num_online_cpus());
>> +		txq_info->ntxq = rounddown(i, adap->params.nports);
>> +		if (txq_info->ntxq <= 0) {
>> +			dev_warn(adap->pdev_dev, "Crypto Tx Queues can't be zero\n");
>> +			return -EINVAL;
>> +		}
> Shouldn't we free txq_info in the error case?
Yes, Will fix this in V2. Thanks.
>
> Regards,
> Lino