netdev - Re: [PATCH] net/sysfs: Remove devices without receive buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181013.165056.111476046287532695.davem@davemloft.net>
Date:   Sat, 13 Oct 2018 16:50:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mwb@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        alexander.h.duyck@...el.com, tyhicks@...onical.com,
        jeffrey.t.kirsher@...el.com, amritha.nambiar@...el.com,
        joe@...ches.com, dmitry.torokhov@...il.com, decot@...glers.com,
        roopa@...ulusnetworks.com, xiyou.wangcong@...il.com,
        nfont@...ux.vnet.ibm.com, minkim@...ibm.com,
        tyreld@...ux.vnet.ibm.com, tlfalcon@...ux.vnet.ibm.com
Subject: Re: [PATCH] net/sysfs: Remove devices without receive buffers

From: Michael Bringmann <mwb@...ux.vnet.ibm.com>
Date: Sat, 13 Oct 2018 17:05:28 -0500

> Testing ran into a case where a network device was created and
> initialized, but then removed from the system before accepting
> traffic through it.  In this case, no receive buffers were added
> to the device prior to attempting to release the driver.  This
> resulted in generation of a WARNING notice/stack trace in the
> console log like,

That's not legal.

The device must setup all of this kind of state before calling
register_netdevice().  And this must happen for reasons other than the
crash situation mentioned here.

Please fix the ibmvnic driver to not register partially setup netdev
objects.

Thank you.