netdev - Re: [PATCH bpf-next] bpf: Fix dev pointer dereference from sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181014060443.xahkin2n4jjjxqt2@ast-mbp.dhcp.thefacebook.com>
Date:   Sat, 13 Oct 2018 23:04:44 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Joe Stringer <joe@...d.net.nz>
Cc:     daniel@...earbox.net, netdev@...r.kernel.org,
        dan.carpenter@...cle.com, ast@...nel.org
Subject: Re: [PATCH bpf-next] bpf: Fix dev pointer dereference from sk_skb

On Fri, Oct 12, 2018 at 02:50:53PM -0700, Joe Stringer wrote:
> Dan Carpenter reports:
> 
> The patch 6acc9b432e67: "bpf: Add helper to retrieve socket in BPF"
> from Oct 2, 2018, leads to the following Smatch complaint:
> 
>     net/core/filter.c:4893 bpf_sk_lookup()
>     error: we previously assumed 'skb->dev' could be null (see line 4885)
> 
> Fix this issue by checking skb->dev before using it.
> 
> Signed-off-by: Joe Stringer <joe@...d.net.nz>

Applied, Thanks