netdev - Re: [PATCH iproute2] json: make 0xhex handle u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181015093419.3cb83797@xeon-e3>
Date:   Mon, 15 Oct 2018 09:34:19 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Sabrina Dubroca <sd@...asysnail.net>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH iproute2] json: make 0xhex handle u64

On Fri, 12 Oct 2018 17:34:32 +0200
Sabrina Dubroca <sd@...asysnail.net> wrote:

> Stephen converted macsec's sci to use 0xhex, but 0xhex handles
> unsigned int's, not 64 bits ints. Thus, the output of the "ip macsec
> show" command is mangled, with half of the SCI replaced with 0s:
> 
> # ip macsec show
> 11: macsec0: [...]
>     cipher suite: GCM-AES-128, using ICV length 16
>     TXSC: 0000000001560001 on SA 0
> 
> # ip -d link show macsec0
> 11: macsec0@...3: [...]
>     link/ether 52:54:00:12:01:56 brd ff:ff:ff:ff:ff:ff promiscuity 0 
>     macsec sci 5254001201560001 [...]
> 
> where TXSC and sci should match.
> 
> Fixes: c0b904de6211 ("macsec: support JSON")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Thanks for finding this. We should add JSON (and macsec) to tests.