netdev - [PATCH -next] fore200e: fix missing unlock on error in bsq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Oct 2018 03:07:16 +0000
From:   Wei Yongjun <weiyongjun1@...wei.com>
To:     Chas Williams <3chas3@...il.com>, Christoph Hellwig <hch@....de>
CC:     Wei Yongjun <weiyongjun1@...wei.com>,
        <linux-atm-general@...ts.sourceforge.net>,
        <netdev@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: [PATCH -next] fore200e: fix missing unlock on error in bsq_audit()

Add the missing unlock before return from function bsq_audit()
in the error handling case.

Fixes: 1d9d8be91788 ("fore200e: check for dma mapping failures")
Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
---
 drivers/atm/fore200e.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
index 2b5dc8f..ffc07ab 100644
--- a/drivers/atm/fore200e.c
+++ b/drivers/atm/fore200e.c
@@ -1606,6 +1606,7 @@ int bsq_audit(int where, struct host_bsq* bsq, int scheme, int magn)
     if (dma_mapping_error(fore200e->dev, tpd->tsd[0].buffer)) {
 	if (tx_copy)
 	    kfree(data);
+	spin_unlock_irqrestore(&fore200e->q_lock, flags);
 	return -ENOMEM;
     }
     tpd->tsd[ 0 ].length = tx_len;