netdev - Re: [PATCH bpf-next 0/2] nfp: bpf: improve offload checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181016222558.ogzbxkinarjqn6sb@ast-mbp.dhcp.thefacebook.com>
Date:   Tue, 16 Oct 2018 15:26:00 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     daniel@...earbox.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com
Subject: Re: [PATCH bpf-next 0/2] nfp: bpf: improve offload checks

On Tue, Oct 16, 2018 at 03:19:08PM -0700, Jakub Kicinski wrote:
> Hi,
> 
> this set adds check to make sure offload behaviour is correct.
> First when atomic counters are used, we must make sure the map
> does not already contain data we did not prepare for holding
> atomics.
> 
> Second patch double checks vNIC capabilities for program offload
> in case program is shared by multiple vNICs with different
> constraints.

1st patch is quite a hack, but until we have proper BTF annotations
I don't see any other way to solve it.

Applied, Thanks