netdev - Re: [PATCH net v3] net/sched: cls_api: add missing validation of netlink attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181015.214927.1659837970561729210.davem@davemloft.net>
Date:   Mon, 15 Oct 2018 21:49:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     dsahern@...il.com, jhs@...atatu.com, netdev@...r.kernel.org
Subject: Re: [PATCH net v3] net/sched: cls_api: add missing validation of
 netlink attributes

From: Davide Caratti <dcaratti@...hat.com>
Date: Wed, 10 Oct 2018 22:00:58 +0200

> Similarly to what has been done in 8b4c3cdd9dd8 ("net: sched: Add policy
> validation for tc attributes"), fix classifier code to add validation of
> TCA_CHAIN and TCA_KIND netlink attributes.
> 
> tested with:
>  # ./tdc.py -c filter
> 
> v2: Let sch_api and cls_api share nla_policy they have in common, thanks
>     to David Ahern.
> v3: Avoid EXPORT_SYMBOL(), as validation of those attributes is not done
>     by TC modules, thanks to Cong Wang.
>     While at it, restore the 'Delete / get qdisc' comment to its orginal
>     position, just above tc_get_qdisc() function prototype.
> 
> Fixes: 5bc1701881e39 ("net: sched: introduce multichain support for filters")
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Applied and queued up for -stable.