netdev - Re: [PATCH net-next] nfp: devlink port split support for 1x100G CXP NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181015.223105.2196222995215268900.davem@davemloft.net>
Date:   Mon, 15 Oct 2018 22:31:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com, rgoodfel@....edu
Subject: Re: [PATCH net-next] nfp: devlink port split support for 1x100G
 CXP NIC

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Fri, 12 Oct 2018 11:09:01 -0700

> From: Ryan C Goodfellow <rgoodfel@....edu>
> 
> This commit makes it possible to use devlink to split the 100G CXP
> Netronome into two 40G interfaces. Currently when you ask for 2
> interfaces, the math in src/nfp_devlink.c:nfp_devlink_port_split
> calculates that you want 5 lanes per port because for some reason
> eth_port.port_lanes=10 (shouldn't this be 12 for CXP?). What we really
> want when asking for 2 breakout interfaces is 4 lanes per port. This
> commit makes that happen by calculating based on 8 lanes if 10 are
> present.
> 
> Signed-off-by: Ryan C Goodfellow <rgoodfel@....edu>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Greg Weeks <greg.weeks@...ronome.com>

Applied.