netdev - Re: [PATCH net,stable 1/1] net: fec: don't dump RX FIFO register when not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181015.225312.1278127205544211615.davem@davemloft.net>
Date:   Mon, 15 Oct 2018 22:53:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     unlisted-recipients:; (no To-header on input)
Cc:     netdev@...r.kernel.org, tremyfr@...il.com
Subject: Re: [PATCH net,stable 1/1] net: fec: don't dump RX FIFO register
 when not available

From: Andy Duan <fugang.duan@....com>
Date: Mon, 15 Oct 2018 05:19:00 +0000

> From: Fugang Duan <fugang.duan@....com>
> 
> Commit db65f35f50e0 ("net: fec: add support of ethtool get_regs") introduce
> ethool "--register-dump" interface to dump all FEC registers.
> 
> But not all silicon implementations of the Freescale FEC hardware module
> have the FRBR (FIFO Receive Bound Register) and FRSR (FIFO Receive Start
> Register) register, so we should not be trying to dump them on those that
> don't.
> 
> To fix it we create a quirk flag, FEC_QUIRK_HAS_RFREG, and check it before
> dump those RX FIFO registers.
> 
> Signed-off-by: Fugang Duan <fugang.duan@....com>

Applied and queued up for -stable.