netdev - Re: [PATCH bpf] bpf: fix doc of bpf_skb_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30d2bbce-4749-f02a-ba4a-891d4336659e@netronome.com>
Date:   Wed, 17 Oct 2018 16:40:36 +0100
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>, ast@...nel.org,
        daniel@...earbox.net, davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH bpf] bpf: fix doc of bpf_skb_adjust_room() in uapi

2018-10-17 16:24 UTC+0200 ~ Nicolas Dichtel <nicolas.dichtel@...nd.com>
> len_diff is signed.
> 
> Fixes: fa15601ab31e ("bpf: add documentation for eBPF helpers (33-41)")
> CC: Quentin Monnet <quentin.monnet@...ronome.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> ---
>   include/uapi/linux/bpf.h       | 2 +-
>   tools/include/uapi/linux/bpf.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
> index 66917a4eba27..c4ffe91d5598 100644
> --- a/include/uapi/linux/bpf.h
> +++ b/include/uapi/linux/bpf.h
> @@ -1430,7 +1430,7 @@ union bpf_attr {
>    * 	Return
>    * 		0 on success, or a negative error in case of failure.
>    *
> - * int bpf_skb_adjust_room(struct sk_buff *skb, u32 len_diff, u32 mode, u64 flags)
> + * int bpf_skb_adjust_room(struct sk_buff *skb, s32 len_diff, u32 mode, u64 flags)
>    * 	Description
>    * 		Grow or shrink the room for data in the packet associated to
>    * 		*skb* by *len_diff*, and according to the selected *mode*.
> diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
> index 66917a4eba27..c4ffe91d5598 100644
> --- a/tools/include/uapi/linux/bpf.h
> +++ b/tools/include/uapi/linux/bpf.h
> @@ -1430,7 +1430,7 @@ union bpf_attr {
>    * 	Return
>    * 		0 on success, or a negative error in case of failure.
>    *
> - * int bpf_skb_adjust_room(struct sk_buff *skb, u32 len_diff, u32 mode, u64 flags)
> + * int bpf_skb_adjust_room(struct sk_buff *skb, s32 len_diff, u32 mode, u64 flags)
>    * 	Description
>    * 		Grow or shrink the room for data in the packet associated to
>    * 		*skb* by *len_diff*, and according to the selected *mode*.
> 

Correct, thank you Nicolas! :)

Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>