netdev - Re: [PATCH] net-xfrm: add build time cfg option to PF_KEY SHA256 to use RFC4868-compliant truncation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181017055950.m3wpucoyobt43k44@gondor.apana.org.au>
Date:   Wed, 17 Oct 2018 13:59:50 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Maciej Żenczykowski <zenczykowski@...il.com>
Cc:     maze@...gle.com, davem@...emloft.net, steffen.klassert@...unet.com,
        netdev@...r.kernel.org, lorenzo@...gle.com
Subject: Re: [PATCH] net-xfrm: add build time cfg option to PF_KEY SHA256 to
 use RFC4868-compliant truncation

Maciej Żenczykowski <zenczykowski@...il.com> wrote:
>
> +#if IS_ENABLED(CONFIG_XFRM_HMAC_SHA256_RFC4868)
> +                       .icv_truncbits = 128,
> +#else
>                        .icv_truncbits = 96,
> +#endif

Nack.  We don't want a build-time configuration knob for this.
This needs to be decided at run-time.

In fact you can already do this at run-time anyway through the
xfrm interface.  So please please please just ditch whatever that
you're using that's still glued to the long-obsolete (more than a
decade) af_key interface and switch it over to xfrm.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt