netdev - Re: [PATCH] iwlwifi: mvm: remove set but not used variable 'he_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f98ae961fa880d9c2b9704ea252326d6cc6ab2e1.camel@intel.com>
Date:   Wed, 17 Oct 2018 10:16:45 +0300
From:   Luciano Coelho <luciano.coelho@...el.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        Johannes Berg <johannes.berg@...el.com>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Intel Linux Wireless <linuxwifi@...el.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Golan Ben Ami <golan.ben.ami@...el.com>,
        Sara Sharon <sara.sharon@...el.com>,
        Shaul Triebitz <shaul.triebitz@...el.com>,
        Liad Kaufman <liad.kaufman@...el.com>
Cc:     linux-wireless@...r.kernel.org, kernel-janitors@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] iwlwifi: mvm: remove set but not used variable
 'he_phy_data'

On Fri, 2018-10-05 at 10:47 +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c: In function
> 'iwl_mvm_rx_mpdu_mq':
> drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c:1386:7: warning:
>  variable 'he_phy_data' set but not used [-Wunused-but-set-variable]
>    u64 he_phy_data;
>    
> 'he_phy_data' never used since be introduce in
> commit 18ead597daa1 ("iwlwifi: support new rx_mpdu_desc api")
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---

Thanks, Yue! This was a merge damage when I applied the HE patches for
iwlwifi.

I've queued this and will send it out as part of the series for 4.21. 
Then it will trickle down as needed.

--
Cheers,
Luca.