netdev - Re: [PATCH net-next] net: ena: Fix Kconfig dependencies X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Oct 2018 11:37:06 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     netanel@...zon.com, davem@...emloft.net, netdev@...r.kernel.org
Cc:     akiyano@...zon.com, alisaidi@...zon.com, dwmw@...zon.com,
        zorik@...zon.com, matua@...zon.com, saeedb@...zon.com,
        msw@...zon.com, aliguori@...zon.com, nafea@...zon.com,
        gtzalik@...zon.com
Subject: Re: [PATCH net-next] net: ena: Fix Kconfig dependencies X86

Hello!

On 17.10.2018 11:16, netanel@...zon.com wrote:

> From: Netanel Belgazal <netanel@...zon.com>
>
> The Kconfig limitation of X86 is to too wide.
> The ENA driver only requires a little endian dependency.
>
> Change the dependency to be on little endian CPU.
>
> Signed-off-by: Netanel Belgazal <netanel@...zon.com>
> ---
>  drivers/net/ethernet/amazon/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amazon/Kconfig b/drivers/net/ethernet/amazon/Kconfig
> index 99b30353541a..f4d16c7e104f 100644
> --- a/drivers/net/ethernet/amazon/Kconfig
> +++ b/drivers/net/ethernet/amazon/Kconfig
> @@ -17,7 +17,7 @@ if NET_VENDOR_AMAZON
>
>  config ENA_ETHERNET
>  	tristate "Elastic Network Adapter (ENA) support"
> -	depends on (PCI_MSI && X86)
> +	depends on (PCI_MSI && !CPU_BIG_ENDIAN)

     Parens not needed here. High time to remove them, I think.

[...]

MBR, Sergei