netdev - Re: [PATCH net-next] bnxt_en: Copy and paste bug in extended tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLiknjz+sv4rxWPHO0aHVDn_acpaMJODYMxeBhpftV7UWhA@mail.gmail.com>
Date:   Thu, 18 Oct 2018 07:32:52 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     David Miller <davem@...emloft.net>,
        Netdev <netdev@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] bnxt_en: Copy and paste bug in extended tx_stats

On Thu, Oct 18, 2018 at 1:02 AM Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> The struct type was copied from the line before but it should be "tx"
> instead of "rx".  I have reviewed the code and I can't immediately see
> that this bug causes a runtime issue.
>
> Fixes: 36e53349b60b ("bnxt_en: Add additional extended port statistics.")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks.  Luckily, we did not use sizeof(*bp->hw_tx_port_stats_ext) to
allocate the memory, so there is no run-time issue.

Acked-by: Michael Chan <michael.chan@...adcom.com>