netdev - Re: [iproute PATCH] rdma: Fix for ineffective check in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181018161712.GR30406@orbyte.nwl.cc>
Date:   Thu, 18 Oct 2018 18:17:12 +0200
From:   Phil Sutter <phil@....cc>
To:     David Ahern <dsahern@...il.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org, Arkadi Sharshevsky <arkadis@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>
Subject: Re: [iproute PATCH] rdma: Fix for ineffective check in add_filter()

Hi,

On Thu, Oct 18, 2018 at 09:27:47AM -0600, David Ahern wrote:
> On 10/18/18 5:41 AM, Phil Sutter wrote:
> > With 'name' field defined as array in struct filters, it will always
> > contain a value irrespective of whether a name was assigned or not.
> > 
> > Fix this by turning the field into a const char pointer.
> > 
> > Fixes: 8cd644095842a ("devlink: Add support for devlink resource abstraction")
> 
> Stale paste buffer? Seems like the correct tag is
> Fixes: 1174be72d1b4c ("rdma: Add filtering infrastructure")

Oh, indeed. Also the wrong person in Cc: Arkadi is innocent, culprit
patch came from Leon.

Stephen, should I respin or will you correct the Fixes tag?

Thanks, Phil