netdev - RE: [PATCH net-next] netpoll: allow cleanup to be synchronous

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Oct 2018 17:47:25 +0000
From:   "Banerjee, Debabrata" <dbanerje@...mai.com>
To:     'Neil Horman' <nhorman@...driver.com>
CC:     David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] netpoll: allow cleanup to be synchronous

> From: Neil Horman <nhorman@...driver.com> 

> The team driver still seems
> to be an outlier there though I think , in that it doesn't guarantee the holding
> of rtnl in its port add/delete paths.

Not seeing where this is the case in the team driver today? They were actually
calling __netpoll_cleanup synchronously already.

> It might be worth cleaning that up and simply replacing all the calls to
> __netpoll_free_async with direct calls to __netpoll_cleanup.  That would let
> you eliminate the former function alltogether.

I believe v2 accomplishes that, please review.

-Deb