netdev - Re: [iproute2 PATCH] tc: flower: Classify packets based port ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59aaf08b-3da9-2574-2dbd-50a686d6b195@intel.com>
Date:   Thu, 18 Oct 2018 11:25:40 -0700
From:   "Nambiar, Amritha" <amritha.nambiar@...el.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     stephen@...workplumber.org, netdev@...r.kernel.org,
        jakub.kicinski@...ronome.com, sridhar.samudrala@...el.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com
Subject: Re: [iproute2 PATCH] tc: flower: Classify packets based port ranges

On 10/18/2018 5:21 AM, Jiri Pirko wrote:
> Fri, Oct 12, 2018 at 03:54:42PM CEST, amritha.nambiar@...el.com wrote:
> 
> [...]
> 
>> @@ -1516,6 +1625,22 @@ static int flower_print_opt(struct filter_util *qu, FILE *f,
>> 	if (nl_type >= 0)
>> 		flower_print_port("src_port", tb[nl_type]);
>>
>> +	if (flower_port_range_attr_type(ip_proto, FLOWER_ENDPOINT_DST, &range)
>> +	    == 0) {
>> +		flower_print_port_range("dst_port_min",
>> +					tb[range.min_port_type]);
>> +		flower_print_port_range("dst_port_max",
>> +					tb[range.max_port_type]);
> 
> The input and output of iproute2 utils, tc included should be in sync.
> So you need to print "range x-y" here.
> 

Agree, will fix in v2. Thanks!

> 
>> +	}
>> +
>> +	if (flower_port_range_attr_type(ip_proto, FLOWER_ENDPOINT_SRC, &range)
>> +	    == 0) {
>> +		flower_print_port_range("src_port_min",
>> +					tb[range.min_port_type]);
>> +		flower_print_port_range("src_port_max",
>> +					tb[range.max_port_type]);
>> +	}
>> +
>> 	flower_print_tcp_flags("tcp_flags", tb[TCA_FLOWER_KEY_TCP_FLAGS],
>> 			       tb[TCA_FLOWER_KEY_TCP_FLAGS_MASK]);
>>
>>