netdev - Re: [PATCH linux-firmware] linux-firmware: liquidio: fix GPL compliance issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Oct 2018 15:04:12 -0400
From:   Josh Boyer <jwboyer@...nel.org>
To:     "John W. Linville" <linville@...driver.com>
Cc:     Felix Manlunas <Felix.Manlunas@...ium.com>,
        Linux Firmware <linux-firmware@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Florian Weimer <fweimer@...hat.com>, Manish.Awasthi@...ium.com,
        Manojkumar.Panicker@...ium.com, Faisal.Masood@...ium.com,
        Raghu.Vatsavayi@...ium.com, Derek.Chickles@...ium.com,
        Satananda.Burla@...ium.com
Subject: Re: [PATCH linux-firmware] linux-firmware: liquidio: fix GPL
 compliance issue

On Wed, Oct 17, 2018 at 5:09 PM John W. Linville <linville@...driver.com> wrote:
>
> On Wed, Oct 17, 2018 at 07:34:42PM +0000, Manlunas, Felix wrote:
> > On Fri, Sep 28, 2018 at 04:50:51PM -0700, Felix Manlunas wrote:
> > > Part of the code inside the lio_vsw_23xx.bin firmware image is under GPL,
> > > but the LICENCE.cavium file neglects to indicate that.  However,
> > > LICENCE.cavium does correctly specify the license that covers the other
> > > Cavium firmware images that do not contain any GPL code.
> > >
> > > Fix the GPL compliance issue by adding a new file, LICENCE.cavium_liquidio,
> > > which correctly shows the GPL boilerplate.  This new file specifies the
> > > licenses for all liquidio firmware, including the ones that do not have
> > > GPL code.
> > >
> > > Change the liquidio section of WHENCE to point to LICENCE.cavium_liquidio.
> > >
> > > Reported-by: Florian Weimer <fweimer@...hat.com>
> > > Signed-off-by: Manish Awasthi <manish.awasthi@...ium.com>
> > > Signed-off-by: Manoj Panicker <manojkumar.panicker@...ium.com>
> > > Signed-off-by: Faisal Masood <faisal.masood@...ium.com>
> > > Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>
> > > ---
> > >  LICENCE.cavium_liquidio | 429 ++++++++++++++++++++++++++++++++++++++++++++++++
> > >  WHENCE                  |   2 +-
> > >  2 files changed, 430 insertions(+), 1 deletion(-)
> > >  create mode 100644 LICENCE.cavium_liquidio
> >
> > Hello Maintainers of linux-firmware.git,
> >
> > Any feedback about this patch?
>
> I would prefer to see an offer that included a defined URL for anyone
> to download the source for the kernel in question without having to
> announce themselves. The "send an email to info@...ium.com" offer may
> (or may not) be sufficient for the letter of the law. But it seems
> both fragile and prone to subjective frustrations and delays for
> users to obtain the sources at some future date.

I agree with John here, but I also believe the patch is better than
the current text in the upstream repo.  I've committed it and pushed
it out.  If there are improvements to be made on source availability,
we can take those in a different patch.

Thank you for taking this seriously and responding quickly.

josh