netdev - Re: [PATCH v4.14-stable] sch_netem: restore skb->dev after dequeuing from the rbtree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181018.154348.2028947036934395230.davem@davemloft.net>
Date:   Thu, 18 Oct 2018 15:43:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     cpaasch@...le.com
Cc:     netdev@...r.kernel.org, stable@...r.kernel.org,
        gregkh@...uxfoundation.org, stephen@...workplumber.org,
        edumazet@...gle.com, soheil@...gle.com, weiwan@...gle.com,
        willemb@...gle.com
Subject: Re: [PATCH v4.14-stable] sch_netem: restore skb->dev after
 dequeuing from the rbtree

From: Christoph Paasch <cpaasch@...le.com>
Date: Thu, 18 Oct 2018 13:38:40 -0700

> Upstream commit bffa72cf7f9d ("net: sk_buff rbnode reorg") got
> backported as commit 6b921536f170 ("net: sk_buff rbnode reorg") into the
> v4.14.x-tree.
> 
> However, the backport does not include the changes in sch_netem.c
> 
> We need these, as otherwise the skb->dev pointer is not set when
> dequeueing from the netem rbtree, resulting in a panic:
 ...
> Fixes: 6b921536f170 ("net: sk_buff rbnode reorg")
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Soheil Hassas Yeganeh <soheil@...gle.com>
> Cc: Wei Wang <weiwan@...gle.com>
> Cc: Willem de Bruijn <willemb@...gle.com>
> Signed-off-by: Christoph Paasch <cpaasch@...le.com>
> ---
> 
> Notes:
>     This patch should only make it into v4.14-stable as that's the only branch where
>     the offending commit has been backported to.

Greg, please queue up.