netdev - Re: [net-next PATCH] net: sched: cls_flower: Classify packets using port ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181017.214233.695288699109520404.davem@davemloft.net>
Date:   Wed, 17 Oct 2018 21:42:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     amritha.nambiar@...el.com
Cc:     netdev@...r.kernel.org, jakub.kicinski@...ronome.com,
        sridhar.samudrala@...el.com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [net-next PATCH] net: sched: cls_flower: Classify packets
 using port ranges

From: Amritha Nambiar <amritha.nambiar@...el.com>
Date: Fri, 12 Oct 2018 06:53:30 -0700

> Added support in tc flower for filtering based on port ranges.
> This is a rework of the RFC patch at:
> https://patchwork.ozlabs.org/patch/969595/

You never addressed Cong's feedback asking you to explain why this
can't be simply built using existing generic filtering facilities that
exist already.

I appreciate that you addressed Jiri's feedback, but Cong's feedback is
just as, if not more, important.

Thank you.