netdev - Re: [PATCH net] r8169: fix NAPI handling under high load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181017.222149.1241280289340067644.davem@davemloft.net>
Date:   Wed, 17 Oct 2018 22:21:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     romieu@...zoreil.com
Cc:     hkallweit1@...il.com, nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] r8169: fix NAPI handling under high load

From: Francois Romieu <romieu@...zoreil.com>
Date: Thu, 18 Oct 2018 01:30:45 +0200

> Heiner Kallweit <hkallweit1@...il.com> :
> [...]
>> This issue has been there more or less forever (at least it exists in
>> 3.16 already), so I can't provide a "Fixes" tag. 
> 
> Hardly forever. It fixes da78dbff2e05630921c551dbbc70a4b7981a8fff.

I don't see exactly how that can be true.

That commit didn't change the parts of the NAPI poll processing which
are relevant here, mainly the guarding of the RX and TX work using
the status bits which are cleared.

Maybe I'm missing something?  If so, indeed it would be nice to add
a proper Fixes: tag here.

Thanks!