netdev - Re: netconsole warning in 4.19.0-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181019.104555.830780623382872282.davem@davemloft.net>
Date:   Fri, 19 Oct 2018 10:45:55 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     davej@...emonkey.org.uk
Cc:     mroos@...ux.ee, xiyou.wangcong@...il.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: netconsole warning in 4.19.0-rc7

From: Dave Jones <davej@...emonkey.org.uk>
Date: Fri, 19 Oct 2018 09:47:04 -0400

> On Fri, Oct 19, 2018 at 12:51:38PM +0300, Meelis Roos wrote:
>  > >   > > I took another look at that error path. Turns out this is all we need I
>  > >   > > think..
>  > >   >
>  > >   > With this patch applied on top of 4.19-rc8, I stll get the warning:
>  > >   >
>  > >   > [   13.722919] WARNING: CPU: 0 PID: 0 at kernel/softirq.c:168 __local_bh_enable_ip+0x2e/0x44
>  > > 
>  > > It's going to be a couple days before I get chance to get back to this.
>  > > Did the previous patch in this thread (without the _bh) fare any better?
>  > 
>  > Tried it with rcu_read_unlock() instead, still the same.
> 
> Ok, this is going to take more time than I have.  DaveM, do you want
> to revert 6fe9487892b32cb1c8b8b0d552ed7222a527fe30, or do you want a
> patch doing the same ?
> 
> That'll bring back the rcu warning, but fewer people were complaining
> about that than this new issue..

I'll revert.

Thanks Dave.