netdev - Re: [PATCH net-next] r8169: add support for Byte Queue Limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181020.123652.159121193641882014.davem@davemloft.net>
Date:   Sat, 20 Oct 2018 12:36:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org, fw@...len.de,
        holger@...lied-asynchrony.com
Subject: Re: [PATCH net-next] r8169: add support for Byte Queue Limits

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sat, 20 Oct 2018 12:25:27 +0200

> From: Florian Westphal <fw@...len.de>
> This patch is basically a resubmit of 1e918876853a ("r8169: add support
> for Byte Queue Limits") which was reverted later. The problems causing
> the revert seem to have been fixed in the meantime.
> Only change to the original patch is that the call to
> netdev_reset_queue was moved to rtl8169_tx_clear.
> 
> The Tested-by refers to a system using the RTL8168evl chip version.
> 
> Signed-off-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> Tested-by: Holger Hoffstätte <holger@...lied-asynchrony.com>

Applied.

Heiner, I just want to say how happy I am with the work you've done on
the r8169 driver.  So many long term issues have been resolved, the
driver uses more and more generic facilities instead of reimplementing
things, and it's much cleaner and easier to maintain now.

Thank you!