netdev - Re: [PATCH net] net/ipv6: Fix index counter for unicast addresses in in6_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181020.154409.2031684747234961796.davem@davemloft.net>
Date:   Sat, 20 Oct 2018 15:44:09 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org,
        dsahern@...il.com
Subject: Re: [PATCH net] net/ipv6: Fix index counter for unicast addresses
 in in6_dump_addrs

From: David Ahern <dsahern@...nel.org>
Date: Fri, 19 Oct 2018 10:00:19 -0700

> From: David Ahern <dsahern@...il.com>
> 
> The loop wants to skip previously dumped addresses, so loops until
> current index >= saved index. If the message fills it wants to save
> the index for the next address to dump - ie., the one that did not
> fit in the current message.
> 
> Currently, it is incrementing the index counter before comparing to the
> saved index, and then the saved index is off by 1 - it assumes the
> current address is going to fit in the message.
> 
> Change the index handling to increment only after a succesful dump.
> 
> Fixes: 502a2ffd7376a ("ipv6: convert idev_list to list macros")
> Signed-off-by: David Ahern <dsahern@...il.com>

Applied and queued up for -stable, thanks David.