netdev - Re: [PATCH net-next 2/4] net: phy-c45: Populate autoneg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 22 Oct 2018 14:21:21 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jose Abreu <jose.abreu@...opsys.com>
Cc:     netdev@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Joao Pinto <joao.pinto@...opsys.com>
Subject: Re: [PATCH net-next 2/4] net: phy-c45: Populate autoneg_done callback

On Mon, Oct 22, 2018 at 11:32:47AM +0100, Jose Abreu wrote:
> We already have this callback implemented. Use it in driver structure.
> 
> Signed-off-by: Jose Abreu <joabreu@...opsys.com>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Joao Pinto <joao.pinto@...opsys.com>
> ---
>  drivers/net/phy/phy-c45.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
> index e1225545362d..c0135217b81f 100644
> --- a/drivers/net/phy/phy-c45.c
> +++ b/drivers/net/phy/phy-c45.c
> @@ -330,6 +330,7 @@ struct phy_driver genphy_10g_driver = {
>  	.soft_reset	= gen10g_no_soft_reset,
>  	.config_init    = gen10g_config_init,
>  	.features       = 0,
> +	.aneg_done	= genphy_c45_aneg_done,
>  	.config_aneg    = gen10g_config_aneg,
>  	.read_status    = gen10g_read_status,
>  	.suspend        = gen10g_suspend,

We should probably do something about the naming. I need to look at
the history to understand why we have gen10g_ and genphy_c45_.

    Andrew