netdev - Re: [PATCH net-next 3/4] net: phy-c45: Implement reset/suspend/resume callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8114f345-0efb-9a64-b867-2cfe2fba09ab@synopsys.com>
Date:   Mon, 22 Oct 2018 13:47:48 +0100
From:   Jose Abreu <jose.abreu@...opsys.com>
To:     Andrew Lunn <andrew@...n.ch>, Jose Abreu <jose.abreu@...opsys.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>
CC:     <netdev@...r.kernel.org>, Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Joao Pinto <joao.pinto@...opsys.com>
Subject: Re: [PATCH net-next 3/4] net: phy-c45: Implement reset/suspend/resume
 callbacks

Hello,

On 22-10-2018 13:28, Andrew Lunn wrote:
>>  EXPORT_SYMBOL_GPL(gen10g_resume);
>> @@ -327,7 +381,7 @@ struct phy_driver genphy_10g_driver = {
>>  	.phy_id         = 0xffffffff,
>>  	.phy_id_mask    = 0xffffffff,
>>  	.name           = "Generic 10G PHY",
>> -	.soft_reset	= gen10g_no_soft_reset,
>> +	.soft_reset	= gen10g_soft_reset,
>>  	.config_init    = gen10g_config_init,
>>  	.features       = 0,
>>  	.aneg_done	= genphy_c45_aneg_done,
> Hi Jose
>
> You need to be careful here. There is a reason this is called
> gen10g_no_soft_reset, rather than having an empty
> gen10g_soft_reset. Some PHYs break when you do a reset.  So adding a
> gen10g_soft_reset is fine, but don't change this here, without first
> understanding the history, and talking to Russell King.

Hmm, the reset function only interacts with standard PCS
registers, which should always be available ...

>From my tests I need to do at least 1 reset during power-up so in
ultimate case I can add a feature quirk or similar.

Russell, can you please comment ?

Thanks and Best Regards,
Jose Miguel Abreu

>
> 	      Andrew