netdev - Re: [iproute2 PATCH] bridge: fix vlan show stats formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181022100001.3413fe1c@xeon-e3>
Date:   Mon, 22 Oct 2018 10:00:01 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Tobias Jungel <tobias.jungel@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [iproute2 PATCH] bridge: fix vlan show stats formatting

On Sat, 20 Oct 2018 15:42:33 +0200
Tobias Jungel <tobias.jungel@...il.com> wrote:

> The output of -statistics vlan show was broken previous change for json
> output. This aligns the format to vlan show.
> 
> Signed-off-by: Tobias Jungel <tobias.jungel@...il.com>

This patch causes new warning:
    CC       vlan.o
vlan.c: In function ‘print_vlan_stats_attr’:
vlan.c:492:2: warning: ‘ifname’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  print_color_string(PRINT_FP, COLOR_IFNAME,
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       NULL, "%-16s", ifname);
       ~~~~~~~~~~~~~~~~~~~~~~


Reverting the patch, please fix and resubmit.