netdev - Re: [PATCH nf] netfilter: ipv6: fix oops when defragmenting locally generated fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iKvVNTXBsAV-3EwHaZiV7ZDxpqPM20acJx1t45iwdO1PQ@mail.gmail.com>
Date:   Tue, 23 Oct 2018 07:54:01 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Florian Westphal <fw@...len.de>
Cc:     netfilter-devel@...r.kernel.org,
        Lorenzo Colitti <lorenzo@...gle.com>,
        zenczykowski <zenczykowski@...il.com>,
        netdev <netdev@...r.kernel.org>,
        Maciej Żenczykowski <maze@...gle.com>
Subject: Re: [PATCH nf] netfilter: ipv6: fix oops when defragmenting locally
 generated fragments

On Tue, Oct 23, 2018 at 7:48 AM Florian Westphal <fw@...len.de> wrote:
>
> Unlike ipv4 and normal ipv6 defrag, netfilter ipv6 defragmentation did
> not save/restore skb->dst.
>
> This causes oops when handling locally generated ipv6 fragments, as
> output path needs a valid dst.
>
> Reported-by: Maciej Żenczykowski <zenczykowski@...il.com>
> Fixes: 84379c9afe01 ("netfilter: ipv6: nf_defrag: drop skb dst before queueing")
> Signed-off-by: Florian Westphal <fw@...len.de>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>