netdev - Re: [PATCH net] Revert "net: simplify sock_poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181023.105736.1045050740571467220.davem@davemloft.net>
Date:   Tue, 23 Oct 2018 10:57:36 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     kgraul@...ux.ibm.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, hch@....de,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH net] Revert "net: simplify sock_poll_wait"

From: Karsten Graul <kgraul@...ux.ibm.com>
Date: Tue, 23 Oct 2018 13:40:39 +0200

> This reverts commit dd979b4df817e9976f18fb6f9d134d6bc4a3c317.
> 
> This broke tcp_poll for SMC fallback: An AF_SMC socket establishes an
> internal TCP socket for the initial handshake with the remote peer.
> Whenever the SMC connection can not be established this TCP socket is
> used as a fallback. All socket operations on the SMC socket are then
> forwarded to the TCP socket. In case of poll, the file->private_data
> pointer references the SMC socket because the TCP socket has no file
> assigned. This causes tcp_poll to wait on the wrong socket.
> 
> Signed-off-by: Karsten Graul <kgraul@...ux.ibm.com>

Applied and queued up for -stable, thank you.