netdev - Re: [PATCH net 1/1] qed: Fix static checker warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Oct 2018 11:05:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rahul.verma@...ium.com
Cc:     netdev@...r.kernel.org, Ariel.Elior@...ium.com,
        Dept-EngEverestLinuxL2@...ium.com
Subject: Re: [PATCH net 1/1] qed: Fix static checker warning

From: Rahul Verma <rahul.verma@...ium.com>
Date: Tue, 23 Oct 2018 08:04:24 -0700

> From: Rahul Verma <Rahul.Verma@...ium.com>
> 
> 	Static Checker Warnings:
> 	drivers/net/ethernet/qlogic/qed/qed_main.c:1510 qed_fill_link_capability()
> 	error: uninitialized symbol 'tcvr_state'.
> 	drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask()
> 	error: uninitialized symbol 'transceiver_state'.
> 	drivers/net/ethernet/qlogic/qed/qed_mcp.c:1951 qed_mcp_trans_speed_mask()
> 	error: uninitialized symbol 'transceiver_type'.
> 
> 	Symbols tcvr_state, transceiver_state and transceiver_type
> 	are initialized with respective default state.
> 
> Fixes: c56a8be7e7aa (qed: Add supported link and advertise link to display in ethtool.)

Referenced commits shall be of the form:

	SHA1_ID ("Commit header text.")

Meaning that text must be contained inside of parenthesis and also double quotes.
Please do not forget the double quotes in the future.

> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Rahul Verma <Rahul.Verma@...ium.com>

Fixed, and applied.

Thanks.