netdev - Re: [PATCH net] net/ipv6: Add anycast addresses to a global hashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL6e_pfbKTr0LftQKOkOBLvS4N_mJLi62TS_h_23zuU_pFi+Vg@mail.gmail.com>
Date:   Tue, 23 Oct 2018 14:21:54 -0400
From:   Jeff Barnhill <0xeffeff@...il.com>
To:     eric.dumazet@...il.com
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net] net/ipv6: Add anycast addresses to a global hashtable

Thanks! You are right. I mis-understood net->ifindex.  I think I need
to instead hold the net pointer in the new ipv6_ac_addrlist structure.
Do you see a problem with that?
On Mon, Oct 22, 2018 at 10:26 PM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
>
>
> On 10/22/2018 07:12 PM, Jeff Barnhill wrote:
> > icmp6_send() function is expensive on systems with a large number of
> > interfaces. Every time it’s called, it has to verify that the source
> > address does not correspond to an existing anycast address by looping
> > through every device and every anycast address on the device.  This can
> > result in significant delays for a CPU when there are a large number of
> > neighbors and ND timers are frequently timing out and calling
> > neigh_invalidate().
> >
> > Add anycast addresses to a global hashtable to allow quick searching for
> > matching anycast addresses.  This is based on inet6_addr_lst in addrconf.c.
> >
>
> I do not see this patch being netns aware ?
>
> Also I believe you misunderstood what was stored in net->ifindex
> You can look at dev_new_index() for what I mean.
>